Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_DeviceData_rmsg-definition.txt #677

Merged
merged 4 commits into from
Nov 11, 2019

Conversation

HomeAutoUser
Copy link
Contributor

@HomeAutoUser HomeAutoUser commented Nov 1, 2019

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • fix
  • feature
  • What is the current behavior? (You can also link to an open issue here)
  • What is the new behavior (if this is a feature change)?
  • adaptation test for JSON
  • Run additional tests against pre-release branch of SIGNALDuino_TOOL

@HomeAutoUser HomeAutoUser requested a review from sidey79 November 5, 2019 18:38
@coveralls
Copy link

coveralls commented Nov 10, 2019

Pull Request Test Coverage Report for Build 1902

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 30.138%

Totals Coverage Status
Change from base Build 1893: 0.1%
Covered Lines: 3798
Relevant Lines: 12602

💛 - Coveralls

Added addinal non failing todo subtest for SD_Device_ProtocolList in
pre-release to see if new entrys rise errors
@sidey79
Copy link
Contributor

sidey79 commented Nov 10, 2019

@HomeAutoUser

Ich habe das Abrufen via AttrVal eingebaut und den Test "verdoppelt" damit auch gegen den Branch pre-release getestet wird. Fehler sind allerdings ausschließlich im Travis Log auffindbar. Der PR wird nicht behindert, sollte es zu einem Fehler mit den pre-release Daten kommen

@HomeAutoUser
Copy link
Contributor Author

Also wären wir hier „durch“ nach Übernahme?
Genau schaue ich mir erst alles am PC an weil das kleine Display ist damit immer überfordert vom Handy

@sidey79
Copy link
Contributor

sidey79 commented Nov 11, 2019

Soll ich mergen?

@HomeAutoUser
Copy link
Contributor Author

Kannst du machen, ich erhielt erst Konflikte beim angleichen, so widmete ich mich dem noch nicht.

@sidey79 sidey79 merged commit e26d43c into RFD-FHEM:dev-r34 Nov 11, 2019
@HomeAutoUser HomeAutoUser deleted the dev-r34_test_Dispatch branch November 11, 2019 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants