-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test_DeviceData_rmsg-definition.txt #677
Conversation
HomeAutoUser
commented
Nov 1, 2019
•
edited by sidey79
Loading
edited by sidey79
- Please check if the PR fulfills these requirements
- Tests for the changes have been added / modified (needed for for bug fixes / features)
- commandref has been added / updated (needed for bug fixes / features)
- CHANGED has been updated (needed for bug fixes / features)
- What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
- fix
- feature
- What is the current behavior? (You can also link to an open issue here)
- old name repeat UnitTest - Anregungen | weitere Verfahrensweise | Fragen | Klärungen ... #676 (comment)
- Only tests against master branch of SIGNALDuino_TOOL are executed
- What is the new behavior (if this is a feature change)?
- adaptation test for JSON
- Run additional tests against pre-release branch of SIGNALDuino_TOOL
- adaptation test for JSON
Pull Request Test Coverage Report for Build 1902
💛 - Coveralls |
Added addinal non failing todo subtest for SD_Device_ProtocolList in pre-release to see if new entrys rise errors
Ich habe das Abrufen via AttrVal eingebaut und den Test "verdoppelt" damit auch gegen den Branch pre-release getestet wird. Fehler sind allerdings ausschließlich im Travis Log auffindbar. Der PR wird nicht behindert, sollte es zu einem Fehler mit den pre-release Daten kommen |
Also wären wir hier „durch“ nach Übernahme? |
Soll ich mergen? |
Kannst du machen, ich erhielt erst Konflikte beim angleichen, so widmete ich mich dem noch nicht. |