-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring Agent display #216
base: master
Are you sure you want to change the base?
Conversation
* use canonical title as a name * use orcid URL as title attribute in logo * show affiliation if given as string
@SirkoS thanks for identifying the problem. It needs a solution but I would prefer to move to So I think the PR is essentially correct - solving the issue - but that it should implement I'll leave this comment here for a bit so if you want to fix this, you can, or else I will. pyLODE update sprint due in Ausgust '24. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Settle on one form but move to schema:name
, not dcterms:title
Could it not be all of them, with different priorities? |
I'm a little hesitant to make my change so far tried to make the least amount of changes to fix the issue which was changing the property used in the output. If I change the normalization process, this will not only affect agents but also any other entity using any of I agree that use of On a different note, this is an entirely internal change to pyLODE - this would not be visible in both ontology and documentation. So I'd argue it does not matter which property is used internally and it's safer to change as few lines of code as possible.
Same argument as in the paragraph before. This is an entirely internal thing, so technically you can use whatever property of the 4 ( I have not entirely understood the codebase, so I might be missing something here. |
while using pyLODE, I had some issues with properly showing contributors names.
I investigated a little and found the following:
names are normalized to use
dcterms:title
here (ontpub) and here (vocpub)however, when serializing for html here and here only
sdo:name
is used.in the pull request I changed that to use the canonical
dcterms:title
instead.I also made minor changes to the formatting:
Orcid logo
as before