Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client credentials oauth client provider #176

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

mpgxvii
Copy link
Member

@mpgxvii mpgxvii commented Nov 28, 2024

  • Add support for additional parameters for client credentials ktor oauth lib
  • This would allow setting of additional params such as scope and audience when using this library
  • Currently needed so that this library can be used in the Ory hydra implementation

@yatharthranjan
Copy link
Member

yatharthranjan commented Nov 28, 2024

Why not add those required variables explicitly instead of using a generic map?

@mpgxvii
Copy link
Member Author

mpgxvii commented Nov 28, 2024

Why not add those required variables explicitly instead of using a generic map?

@yatharthranjan Ah okay yes I can add these explicitly. I just thought maybe we would have use cases in the future where we would need it to be more generic. But I think it's better for the params to be set explicitly. 👍

Copy link
Member

@yatharthranjan yatharthranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@yatharthranjan yatharthranjan merged commit cc02f32 into dev Nov 29, 2024
2 of 3 checks passed
@yatharthranjan yatharthranjan deleted the update-oauthclient branch November 29, 2024 13:06
This was referenced Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants