Redis Publisher connection error in docker container #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think tests are failing because of this - https://travis-ci.community/t/java-home-is-not-exported-for-arm64-architecture/6993 |
|
Yes, you're right. |
|
Should I edit the travis file to solve that? |
|
No, its ok to leave for now as travis should fix it soon. And we are planning to move to github actions soon. |
| @@ -11,7 +11,7 @@ | |||
|
|
|||
| class RedisPublisher(Publisher): | |||
|
|
|||
| def __init__(self, connection: RedisConnection = RedisConnection(), | |||
| def __init__(self, connection: RedisConnection, | |||
| publisher_thread_pool: ThreadPoolExecutor = ThreadPoolExecutor(max_workers=4)): | |||
There was a problem hiding this comment.
Do you think the other defaults will also not be honoured? Like the thread_pool?
There was a problem hiding this comment.
I think the issue here would only occur because of this default since it uses self.connect() init which would throw an exception when connection is not successful. Other default arguments do not share the same issue.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved the issue #15. The error was because of dynamic import initialises default argument
RedisConnectionwhich leads it to connect withlocalhost:6379and throw ConnectionError.