Add a safeguard to map command

[catornot]

adds safeguard to the map command that prevents it from executing if the map is invalid.

I wanted to implement this originally as a plugin but I think it might be quite useful for everyone.

[ASpoonPlaysGames]

Would be nice to get this merged, just a couple of questions/suggestions

[Alystrasz]

Game does not crash anymore when passed an invalid map name, and prints a nice warning message instead.

[F1F7Y]

I don't like how you replace the con command callback and then call the original. The original is just a few lines of code so I'd prefer we hook it and reconstruct it.

I can do this if you don't have the time to do so.

[catornot]

I don't like how you replace the con command callback and then call the original. The original is just a few lines of code so I'd prefer we hook it and reconstruct it.

I can't find the function for it in ghidra 😞

[F1F7Y]

I can't find the function for it in ghidra 😞

engine.dll + 0x15B340

[catornot]

ghidra decided to combine Host_map_f and FUN_0015b220 lol

[Alystrasz]

Still works as expected, game does not crash when command is given an incorrect map name.

[ASpoonPlaysGames]

Changes that I requested were addressed/are now outdated. Code looks good to me

[Jan200101]

code looks good

extra check if the map actually exists may be overkill, but the vanilla map command is fragile so its probably best to guard it from inputs it may not be capable of handling

[ASpoonPlaysGames]

extra check if the map actually exists may be overkill, but the vanilla map command is fragile so its probably best to guard it from inputs it may not be capable of handling

Game crashes if you try and do a map command with an invalid map

[Jan200101]

yeah my tired brain thought about the wrong thing.
I ment to say no map being specified at all and just running the original command if the inputs are good.
But the command is fragile so its best to gut it completely

[GeckoEidechse]

I tested the following inputs for the PR

map           <-- shows appropriate warning as expected
map mp_glich  <-- shows appropriate warning as expected
map mp_glitch <-- loads map as expected

without this PR what happens

map           <-- nothing happens
map mp_glich  <-- crashes game with error message about missing map
map mp_glitch <-- loads map as expected

Didn't do any code review as others have already covered that part anyway and I don't feel qualified enough apart from spotting basic errors.

requested changes were implemented

[GeckoEidechse]

@F1F7Y I dismissed your review that requests changes as the requested changes have since been implemented as far as I can tell and the lack of a re-review was blocking the PR ^^

[snake-biscuits]

Has this been tested on maps which are in an installed mod but that mod is disabled?
Because those maps are listed when you type “map mp_” in console

Looking at the code changes it seems not…
Might test for myself & bug report / try a fix later

[GeckoEidechse]

This breaks docker image as per pg9182/northstar-dedicated#70