Revise <p> style decisions #439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnnuiL
added
t: refactor
|
@EnnuiL I'd prefer if we split this into two, the <p> fixes make it very difficult to sort out the dictionary changes edit: huh I did not know github comments supported html |
heck |
|
I mean you can look at the commits but two prs would be cleaner :p |
EnnuiL
changed the title
|
This is still a draft due to aaaaaaaa |
supersaiyansubtlety
requested changes
Jun 4, 2023
Comment on lines
7
to
11
| COMMENT <li>The annotation itself is not obfuscated.</li> | ||
| COMMENT <li>If a class is annotated, it is not obfuscated. It's not yet clear if its | ||
| COMMENT members will always become deobfuscated as well.</li> | ||
| COMMENT <li>If a member is annotated, it and its containing class is not obfuscated, | ||
| COMMENT but other members in the same class may stay obfuscated.</li> |
There was a problem hiding this comment.
Suggested change
| COMMENT <li>The annotation itself is not obfuscated.</li> | |
| COMMENT <li>If a class is annotated, it is not obfuscated. It's not yet clear if its | |
| COMMENT members will always become deobfuscated as well.</li> | |
| COMMENT <li>If a member is annotated, it and its containing class is not obfuscated, | |
| COMMENT but other members in the same class may stay obfuscated.</li> | |
| COMMENT <li>The annotation itself is not obfuscated.</li> | |
| COMMENT <li>If a class is annotated, it is not obfuscated. It's not yet clear if its | |
| COMMENT members will always become deobfuscated as well.</li> | |
| COMMENT <li>If a member is annotated, it and its containing class is not obfuscated, | |
| COMMENT but other members in the same class may stay obfuscated.</li> |
NoComment1105
added
update-base
|
🚀 Target branch has been updated to 1.20 |
github-actions
bot
removed
the
update-base
EnnuiL
added
the
update-base
|
🚀 Target branch has been updated to 1.20.1-rc1 |
github-actions
bot
added
v: snapshot
ix0rai
added
the
update-base
|
🚀 Target branch has been updated to 1.20.1 |
github-actions
bot
removed
the
update-base
ix0rai
added
v: release
ix0rai
added
the
update-base
|
🚀 Target branch has been updated to 23w31a |
|
🚨 Please fix merge conflicts before this can be merged |
github-actions
bot
added
v: snapshot
ix0rai
added
the
update-base
|
🚀 Target branch has been updated to 23w32a |
|
🚨 Please fix merge conflicts before this can be merged |
github-actions
bot
removed
the
update-base
|
I'll close this PR due to the sheer unmaintainability of it; this might be need to be done in many PRs |
|
that's what aurora has been doing for ages :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
i need to review this myself