Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AboutCoordinator memory leak #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

AboutCoordinator memory leak #7

wants to merge 3 commits into from

Conversation

pauljohanneskraft
Copy link
Collaborator

This MR solves #5 and #6 by using the most recent XCoordinator version, setting DEAD_CODE_STRIPPING to NO and overriding the viewController property in the AboutCoordinator.

@pauljohanneskraft pauljohanneskraft self-assigned this Dec 9, 2019
d2vydov
d2vydov suggested changes Dec 9, 2019
View reviewed changes
Copy link

@d2vydov d2vydov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to check this - this changes are not fixes a problem

@d2vydov
Copy link

d2vydov commented Dec 9, 2019

image

there is a some memory leak with child coordinator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d2vydov d2vydov d2vydov requested changes

Assignees

@pauljohanneskraft pauljohanneskraft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pauljohanneskraft @d2vydov