Merge pull request #2 from QuiNovas/develop

forgot the “local” descriptor
QuiNovas · Aug 23, 2018 · da95f0e · da95f0e
2 parents 998f626 + 7be7c27
commit da95f0e
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/cloudwatch.tf b/cloudwatch.tf
@@ -14,11 +14,11 @@ data "aws_iam_policy_document" "cloudwatch_assume_role" {
 
 resource "aws_iam_role" "cloudwatch_logs" {
   assume_role_policy = "${data.aws_iam_policy_document.cloudwatch_assume_role.json}"
-  name = "${associated_resource_name}"
+  name = "${local.associated_resource_name}"
 }
 
 resource "aws_cloudwatch_log_group" "cloudtrail" {
-  name              = "${associated_resource_name}"
+  name              = "${local.associated_resource_name}"
   retention_in_days = 7
 }
 

diff --git a/kms-key.tf b/kms-key.tf
@@ -64,7 +64,7 @@ resource "aws_kms_key" "cloudtrail" {
 }
 
 resource "aws_kms_alias" "cloudtrail" {
-  name          = "alias/${associated_resource_name}"
+  name          = "alias/${local.associated_resource_name}"
   target_key_id = "${aws_kms_key.cloudtrail.key_id}"
 }
 
diff --git a/s3-bucket.tf b/s3-bucket.tf
@@ -1,6 +1,6 @@
 resource "aws_s3_bucket" "cloudtrail" {
   acl     = "log-delivery-write"
-  bucket  = "${associated_resource_name}"
+  bucket  = "${local.associated_resource_name}"
 
   lifecycle_rule {
     id = "log"
@@ -23,7 +23,7 @@ resource "aws_s3_bucket" "cloudtrail" {
 
   logging {
     target_bucket = "${var.log_bucket}"
-    target_prefix = "s3/${associated_resource_name}/"
+    target_prefix = "s3/${local.associated_resource_name}/"
   }
 }
 

diff --git a/sns-topic.tf b/sns-topic.tf
@@ -1,5 +1,5 @@
 resource "aws_sns_topic" "cloudtrail" {
-  name = "${associated_resource_name}"
+  name = "${local.associated_resource_name}"
 }
 
 data "aws_iam_policy_document" "cloudtrail_sns" {