update message pointer class to PayloadS3Pointer #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versions > 1.1.0 of Java SQS extended client uses PayloadS3Pointer class instead of MessageS3Class awslabs/amazon-sqs-java-extended-client-lib#13
|
Thanks @rishi-dhar! I'll cut a new release tomorrow |
|
@rishi-dhar I'm going to have to make some more modifications to support this. Specifically, I will have to allow users to set the version of the amazon-sqs-java-extended-client to conform to. I'll default it to the new version, but if I don't allow for using the old version then this update may break some folks. Additionally, without the setting a central process handling multiple queues would not be able to deal with a mix of clients on the other side (especially if the user doesn't have control over the other side clients). I'm going to reject this PR tomorrow and do this in the main branch instead of asking you to make all of the changes required... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions > 1.1.0 of Java SQS extended client uses PayloadS3Pointer class instead of MessageS3Class
awslabs/amazon-sqs-java-extended-client-lib#13