Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embeddium X JVM Update #45

Merged
merged 2 commits into from
Jun 2, 2024

Conversation

Cartrigger
Copy link
Collaborator

@Cartrigger Cartrigger commented May 27, 2024

#44
JVM Args are listed here

This PR also adds Embeddium to .1 and .4 of 1.20's, with adding Noisium to all 20s and
This also adds all prior mods to 1.20.4, which was in need.
Also removes modmenu because that is not meant to be there by default, only in devmods by default, but because most people are using devmods now i have to treat both the same.

Cartrigger and others added 2 commits May 25, 2024 23:06
@Cartrigger
Copy link
Collaborator Author

Looks good on my end, all mods added do not have dependencies (other than fabricapi)

@computer-catt
Copy link

colon3

Copy link
Contributor

@thejudge156 thejudge156 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a question, but otherwise looks good.

@thejudge156 thejudge156 merged commit e982b28 into QuestCraftPlusPlus:QuestCraft Jun 2, 2024
1 check passed
Novampr pushed a commit to Refitted-Team/Pojlib-HEF that referenced this pull request Jun 21, 2024
thewiilover pushed a commit to thewiilover/Pojlib that referenced this pull request Jun 24, 2024
CADIndie pushed a commit that referenced this pull request Oct 9, 2024
CADIndie pushed a commit that referenced this pull request Oct 9, 2024
CADIndie pushed a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants