-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embeddium X JVM Update #45
Merged
thejudge156
merged 2 commits into
QuestCraftPlusPlus:QuestCraft
from
Cart-shit:EmbeddiumCraft
Jun 2, 2024
Merged
Embeddium X JVM Update #45
thejudge156
merged 2 commits into
QuestCraftPlusPlus:QuestCraft
from
Cart-shit:EmbeddiumCraft
Jun 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all versions are using mods.json instead of devmods.json
Looks good on my end, all mods added do not have dependencies (other than fabricapi) |
thejudge156
reviewed
Jun 2, 2024
thejudge156
approved these changes
Jun 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a question, but otherwise looks good.
Novampr
pushed a commit
to Refitted-Team/Pojlib-HEF
that referenced
this pull request
Jun 21, 2024
Embeddium X JVM Update
thewiilover
pushed a commit
to thewiilover/Pojlib
that referenced
this pull request
Jun 24, 2024
Embeddium X JVM Update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#44
JVM Args are listed here
This PR also adds Embeddium to .1 and .4 of 1.20's, with adding Noisium to all 20s and
This also adds all prior mods to 1.20.4, which was in need.
Also removes modmenu because that is not meant to be there by default, only in devmods by default, but because most people are using devmods now i have to treat both the same.