Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary check in GET customers #77

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Removed unnecessary check in GET customers #77

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e4357e
Removed unnecessary check in GET customers
nagarwal4 Apr 9, 2024
e741b61
Removed unused usings
nagarwal4 Apr 12, 2024
33e4407
Merge branch 'main' into fix-get-customers
nagarwal4 Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions backend/core/src/Core.Application/Queries/CustomerQueries/GetCustomerQuery.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@
// under the Apache License, Version 2.0. See the NOTICE file at the root
// of this distribution or at http://www.apache.org/licenses/LICENSE-2.0

using Core.Domain;
using Core.Domain.Entities.CustomerAggregate;
using Core.Domain.Exceptions;
using Core.Domain.Repositories;
using MediatR;

Expand Down Expand Up @@ -33,11 +31,6 @@ public async Task<Customer> Handle(GetCustomerQuery request, CancellationToken c
{
var customer = await _customerRepository.GetAsync(request.CustomerCode);

if (customer.Status != CustomerStatus.ACTIVE.ToString() && customer.Status != CustomerStatus.UNDERREVIEW.ToString())
WJRobert marked this conversation as resolved.
Show resolved Hide resolved
{
throw new CustomErrorsException(ApplicationErrorCode.InvalidStatusError.ToString(), request.CustomerCode, "Customer status with this reference is not valid");
}

return customer;
}
}
Expand Down
Loading