Extend token SDK with async methods & fixes #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `GetEnvelope` and `WaitForCompletionAsync` methods to `MockTokenServerProvider`. - Introduced `WaitForCompletionAsync` in `ISubmitFacade` and its implementation in `SubmitFacade`. - Updated `ITokenServerProvider` and `TokenServerProvider` to include new methods and correct syntax errors. - Added `AuthorizationRequired` property to `AlgorandTokenSettings`. - Introduced `EnvelopeResponse` class for detailed response handling. - Corrected array initialization syntax in `TokenServerProvider`. - Enhanced `AlgorandExamples.cs` with better logging and settings adjustments for asset tokens.
- Updated `SubmitOnAlgorandAsync` in `TokenServerProvider.cs` to include an optional `awaitResult` parameter, allowing callers to specify if they wish to wait for the submission to be fully processed. The method's documentation has been updated accordingly to reflect this new functionality. - Added `WaitForCompletionAsync` method in the same file, designed to wait for a token operation to be fully processed. It accepts a unique Nexus identifier (`code`) and an optional `CancellationToken`, continuously checking the operation's status until it is resolved.
This commit introduces significant updates aimed at improving task management and execution control across the codebase. Key changes include the introduction of `CancellationToken` in HTTP response handling and request execution, allowing for better task cancellation and resource conservation. The `IResponseHandler` interface and its implementations, as well as the `RequestBuilder` class, have been updated to support these cancellations effectively. Additionally, enhancements in token submission and waiting mechanisms have been implemented. The `ISubmitFacade` and `ITokenServerProvider` interfaces, along with their implementations, now support optional parameters for task cancellation and waiting for completion, offering improved control over the token submission process on Algorand. Documentation has been improved through the use of `<inheritdoc/>` annotations, promoting cleaner code and reducing redundancy. General code improvements for consistency, including the introduction of optional parameters in various methods, have been made to enhance flexibility and efficiency. These updates collectively contribute to a more robust and flexible codebase, enhancing control over HTTP request handling, task cancellation, and token submission processes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetEnvelopeandWaitForCompletionAsyncmethods toMockTokenServerProvider.WaitForCompletionAsyncinISubmitFacadeand its implementation inSubmitFacade.ITokenServerProviderandTokenServerProviderto include new methods and correct syntax errors.AuthorizationRequiredproperty toAlgorandTokenSettings.EnvelopeResponseclass for detailed response handling.TokenServerProvider.AlgorandExamples.cswith better logging and settings adjustments for asset tokens.