Remove logic around Initializer-s in adapt_node
#191
+17
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neNasko1
requested review from
adityagoel4512,
cbourjau and
jbachurski
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it seems like
adapt_nodeuses some of the constant propagated values as initialisers to the adapted node.After discussing this with @cbourjau it seems like it may be a legacy artefact as it does not break anything downstream. It may have existed in a way to ensure that the initialisers are properly put into the graph, however as demonstrated by the test case they get picked as attributes during the build procedure.
Checklist
CHANGELOG.rstentry