Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark flaky tests as xfail #98

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Mark flaky tests as xfail #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3cc0db
Mark flaky tests as xfail
pavelzw Dec 1, 2023
deeed97
.
pavelzw Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/test_lgbm_compression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ def test_compressed_size(diabetes_toy_df, lgbm_regressor, tmp_path):
assert size_compressed < 0.6 * size


@pytest.mark.xfail(reason="Flaky test")
@pytest.mark.parametrize("compression_method", ["no", "lzma", "gzip", "bz2"])
def test_dump_times(diabetes_toy_df, lgbm_regressor, tmp_path, compression_method):
lgbm_regressor.fit(*diabetes_toy_df)
Expand All @@ -64,6 +65,7 @@ def test_dump_times(diabetes_toy_df, lgbm_regressor, tmp_path, compression_metho
assert dump_time_compressed < factor * dump_time_uncompressed


@pytest.mark.xfail(reason="Flaky test")
@pytest.mark.parametrize("compression_method", ["no", "lzma", "gzip", "bz2"])
def test_load_times(diabetes_toy_df, lgbm_regressor, tmp_path, compression_method):
lgbm_regressor.fit(*diabetes_toy_df)
Expand Down
2 changes: 2 additions & 0 deletions tests/test_sklearn_compression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ def test_compression_size(diabetes_toy_df, random_forest_regressor, tmp_path):
assert size_dtype_reduction < 0.5 * size_no_reduction


@pytest.mark.xfail(reason="Flaky test")
@pytest.mark.parametrize("compression_method", ["no", "lzma", "gzip", "bz2"])
def test_dump_times(
diabetes_toy_df, random_forest_regressor, tmp_path, compression_method
Expand All @@ -113,6 +114,7 @@ def test_dump_times(
assert dump_time_compressed < factor * dump_time_uncompressed


@pytest.mark.xfail(reason="Flaky test")
@pytest.mark.parametrize("compression_method", ["no", "lzma", "gzip", "bz2"])
def test_load_times(
diabetes_toy_df, random_forest_regressor, tmp_path, compression_method
Expand Down