Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add typing overloads for passing file BinaryIO #136

Merged
merged 2 commits into from
Sep 17, 2024
Merged

add typing overloads for passing file BinaryIO #136

merged 2 commits into from
Sep 17, 2024

Conversation

0xbe7a
Copy link
Contributor

@0xbe7a 0xbe7a commented Sep 17, 2024

This enforces setting compression when not passing a filename or Path

@0xbe7a 0xbe7a requested a review from pavelzw as a code owner September 17, 2024 13:00
@0xbe7a 0xbe7a merged commit 36205bb into main Sep 17, 2024
20 checks passed
@0xbe7a 0xbe7a deleted the overload branch September 17, 2024 13:22
Copy link

github-actions bot commented Sep 17, 2024

(benchmark 10903949060 / attempt 1)
Base results / Our results / Change

Model Size Dump Time Load Time
sklearn rf 20M 23.4 MiB / 3.0 MiB / 7.67 x 0.01 s / 0.03 s / 2.51 x 0.02 s / 0.03 s / 1.43 x
sklearn rf 20M lzma 6.5 MiB / 2.0 MiB / 3.21 x 9.31 s / 0.70 s / 0.08 x 0.41 s / 0.15 s / 0.37 x
sklearn rf 200M 238.8 MiB / 30.8 MiB / 7.75 x 0.14 s / 0.23 s / 1.62 x 0.22 s / 0.37 s / 1.66 x
sklearn rf 200M lzma 48.8 MiB / 14.8 MiB / 3.29 x 69.47 s / 12.91 s / 0.19 x 3.17 s / 1.14 s / 0.36 x
sklearn rf 1G 1302.2 MiB / 168.0 MiB / 7.75 x 0.72 s / 1.11 s / 1.53 x 1.15 s / 1.90 s / 1.65 x
sklearn rf 1G lzma 262.4 MiB / 99.1 MiB / 2.65 x 360.49 s / 73.70 s / 0.20 x 16.14 s / 6.80 s / 0.42 x
sklearn gb 2M 2.5 MiB / 1.1 MiB / 2.16 x 0.02 s / 0.21 s / 8.72 x 0.03 s / 0.21 s / 7.31 x
sklearn gb 2M lzma 0.6 MiB / 0.2 MiB / 3.76 x 0.74 s / 0.36 s / 0.48 x 0.07 s / 0.22 s / 3.29 x
lgbm gbdt 2M 2.6 MiB / 1.0 MiB / 2.78 x 0.05 s / 0.18 s / 3.89 x 0.01 s / 0.11 s / 13.88 x
lgbm gbdt 2M lzma 0.9 MiB / 0.5 MiB / 1.90 x 0.90 s / 0.35 s / 0.39 x 0.06 s / 0.11 s / 1.98 x
lgbm gbdt 5M 5.3 MiB / 1.9 MiB / 2.81 x 0.09 s / 0.35 s / 3.81 x 0.02 s / 0.17 s / 10.56 x
lgbm gbdt 5M lzma 1.7 MiB / 0.8 MiB / 1.96 x 2.14 s / 0.71 s / 0.33 x 0.11 s / 0.22 s / 2.11 x
lgbm gbdt 20M 22.7 MiB / 7.6 MiB / 3.00 x 0.39 s / 1.44 s / 3.73 x 0.07 s / 0.77 s / 10.69 x
lgbm gbdt 20M lzma 6.3 MiB / 3.0 MiB / 2.09 x 11.91 s / 3.27 s / 0.27 x 0.41 s / 0.88 s / 2.17 x
lgbm gbdt 100M 101.1 MiB / 33.0 MiB / 3.06 x 1.79 s / 6.55 s / 3.66 x 0.36 s / 34.69 s / 96.95 x
lgbm gbdt 100M lzma 25.6 MiB / 10.6 MiB / 2.41 x 53.10 s / 16.28 s / 0.31 x 1.67 s / 3.79 s / 2.28 x
lgbm rf 10M 10.9 MiB / 3.2 MiB / 3.46 x 0.17 s / 0.41 s / 2.41 x 0.03 s / 0.27 s / 9.82 x
lgbm rf 10M lzma 0.7 MiB / 0.4 MiB / 1.86 x 1.21 s / 0.59 s / 0.49 x 0.08 s / 0.29 s / 3.57 x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant