fix: validate contract secType on null #122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update introduces a validation step to ensure that
contract.SecType
is not null before attempting to retrieve the correctSecurityType
of the contract. Ifcontract.SecType
is null, the update will instead invoke theGetContractDetails()
method using thecomboLeg.ConId
to retrieve the necessary details.Related Issue
N/a
Motivation and Context
The current implementation assumes that
contract.SecType
is always populated, which may not be the case in certain scenarios. This can lead to incorrect or failed attempts to retrieve theSecurityType
of a contract. By validating thatcontract.SecType
is not null, we ensure that the logic for determining theSecurityType
is robust and accurate. Ifcontract.SecType
is null, we use theGetContractDetails()
method as a fallback mechanism, usingcomboLeg.ConId
to retrieve the required information.Requires Documentation Change
N/A
How Has This Been Tested?
ComboOrders
Types of changes
Checklist:
bug-<issue#>-<description>
orfeature-<issue#>-<description>