-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub pipeline to look like libqasm's one. #508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is pending from issue 498 to be fixed. It causes the pytest to not terminate many times, so we disable it for the moment.
Removing Conan cache before build.
Removing Conan cache before build.
It seems that cleaning the Conan cache is effective. I have added it as a preventive measure to the cpp-tests/actions.yaml. This will only be of some effect for the self-hosted runners. But, since the self-hosted runners use containers that cache Conan packages from previous runs, and that can cause different type of problems, it looks like a sensible setup step to perform. Enabled all the jobs.
oschusler
previously approved these changes
Dec 22, 2023
oschusler
previously approved these changes
Jan 2, 2024
rturrado
dismissed
oschusler’s stale review
January 2, 2024 18:13
The merge-base changed after approval.
I will delete this PR because all the changes from it have made it into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we are now using Olaf's new GitHub pipeline.
I have noticed clang++ compiler was never being used. I have added an
inputs.conan_profile
toaction.yaml
.libqasm
is now built in Debug and Release for the following architecture-OS-compiler combos:And also for: