Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decomposition after router missing #492

Open
jvansomeren opened this issue May 10, 2023 · 0 comments
Open

Decomposition after router missing #492

jvansomeren opened this issue May 10, 2023 · 0 comments

Comments

@jvansomeren
Copy link
Collaborator

The optional decomposition to primitives after the router has been omitted during the merge.
This leads to changes in the golden output files of the tests such as:

The only change is that there are 17 non-decomposed swaps now versus decomposed ones before. That is about 3 cycles for each swap more cycles on a duration of a swap of 10 cycles.
That could explain it.
Because a non-decomposed swap reserves all resources (and there are several) for the full 10 cycles, while a decomposed swap only does that for the durations of the individual primitives.

Adding a decomposition pass after the router would prevent this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant