Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifying current tests reduces coverage #491

Open
jvansomeren opened this issue May 9, 2023 · 0 comments
Open

Simplifying current tests reduces coverage #491

jvansomeren opened this issue May 9, 2023 · 0 comments

Comments

@jvansomeren
Copy link
Collaborator

Several golden outputs of tests have non-decomposed swap in their output.
This means that swap wasn't decomposed for this test.
This is fine for testing e.g. the router.
But it is not fine for testing whether the combination of router, decomposition and rc scheduling works for decomposed swaps because
these end-to-end tests are not done now.
So coverage is reduced.
I agree to have simpler tests and have more unit tests.
But we also need to keep some end-to-end tests of semi-realistic applications; when that means that the golden outputs have to be updated on each change of OpenQL, then that is the problem, not the presence of the test and should another way be found to do those end-to-end tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant