Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing plot_histogram when data is sparse #13294

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Shivansh20128
Copy link
Contributor

Summary

I have added a new parameter "ignore_under" in the plot_histogram function. It makes the function ignore all the values in the data dictionary that are below this value.
Documentation for the parameter is also added.
#Resolves #13066

Details and comments

This solves the sparsity problem in the histogram function as mentioned in the issue here.

@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Oct 8, 2024
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

@coveralls
Copy link

coveralls commented Oct 8, 2024

Pull Request Test Coverage Report for Build 11493960266

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • 24 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 88.664%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/visualization/counts_visualization.py 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 1 92.24%
crates/qasm2/src/expr.rs 1 94.02%
crates/qasm2/src/lex.rs 4 92.73%
crates/qasm2/src/parse.rs 18 96.69%
Totals Coverage Status
Change from base Build 11481266566: -0.02%
Covered Lines: 74893
Relevant Lines: 84468

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

plot_histogram should show better when very spread results
3 participants