-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote CONTROL_FLOW_OP_NAMES
to public API
#13057
Conversation
This is generally useful for Qiskit's built-in transpiler passes, and we've had some interest in using it for the same reasons from outside the library. While the control-flow structure from within Rust might change in the future, in the immediate term and from Python space, it feels fair to expose this as public API, since all the information contained in it is certainly already public.
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 10623602313Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jakelishman !
Lazy follow up request -- it would be nice to have an equivalent to qiskit/qiskit/transpiler/preset_passmanagers/generate_preset_pass_manager.py Lines 459 to 464 in b9d5c9c
It came up in Qiskit/qiskit-ibm-runtime#2044 (comment). I will keep it on my list but I can't do it at the moment. |
Summary
This is generally useful for Qiskit's built-in transpiler passes, and we've had some interest in using it for the same reasons from outside the library. While the control-flow structure from within Rust might change in the future, in the immediate term and from Python space, it feels fair to expose this as public API, since all the information contained in it is certainly already public.
Details and comments
Minor request from @ihincks.