Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use job instead of get job by id #19

Merged
merged 1 commit into from
Oct 22, 2024
Merged

feat: use job instead of get job by id #19

merged 1 commit into from
Oct 22, 2024

Conversation

paaragon
Copy link
Collaborator

Summary

This PR deprecates the method get_job_by_id in favor of job

akihikokuroda
akihikokuroda approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@akihikokuroda akihikokuroda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paaragon paaragon merged commit 738b5d2 into main Oct 22, 2024
8 checks passed
@pandasa123 pandasa123 mentioned this pull request Oct 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akihikokuroda akihikokuroda akihikokuroda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paaragon @akihikokuroda