RENDERER: Support vid_framebuffer 2 with classic renderer. #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsvensson
commented
Dec 27, 2024
| strlcat(included_definitions, "#extension GL_ARB_draw_buffers : enable\n", sizeof(included_definitions)); | ||
| } else if (SDL_GL_ExtensionSupported("GL_EXT_draw_buffers")) { | ||
| strlcat(included_definitions, "#extension GL_EXT_draw_buffers : enable\n", sizeof(included_definitions)); | ||
| } |
There was a problem hiding this comment.
This might actually not be needed if OpenGL on macOS is initialized to a higher OpenGL version. Currently it's detected as 0,0 - which enables 2,1 behavior, when it really should get 3.1 or 3.2 behavior or smth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without GL_ARB_draw_buffers, vid_framebuffer 2 results in a black screen on macOS.