BUG: fix failing tests (issue #221) #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* on running QuantitativeReporting selftest from SelfTests module, QuantitativeReportingTests will be executed
|
@fedorov If you see anything suspicious, let me know. Otherwise, I will merge no later than 10pm |
|
No, I don't see anything suspicious, but frankly I am not sure what to look for. Go ahead! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for the reference #221
will close the issue, if tests are succeeding
@cpinter I knot that you had issues in #218 but I would like to have the tests as a separate module as long as Testing is enabled during the build. If you have a better idea, let me know. For now, I will merge this PR and see what the dashboard reports regarding the tests.