WIP: added integration tests and referencing right master volume from segmentation #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fedorov If you find time, maybe you can take a look at the first test case that I created and the way everything is setup including the CMakeLists... |
che85
changed the title
* moved TestDataLogic and QuantitativeReportingTest to separate file * TODO: implement further tests
- referenced master volume is set properly only if SEG will be loaded after referenced volumes has been loaded. This is not always the case though! In some cases scalar volume is loaded, then SEG and in the end the PET SUV, which causes the SEG to set the wrong master volume as master volume - using Subject Hierarchy for achieving querying for the referenced volume - adding references from ReferencedImageSequence besides ReferencedSeriesSequence
|
@fedorov Maybe we can merge this PR? |
|
makes sense, I missed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work on #169
work on #194