Integrate Orchard ZSA Issuance note commitments with Shielded Data action commitments for V6 transactions #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actor orchard_shielded_data_iter and orchard_shielded_data_field macros to use it
…te_commitments to merge Orchard ZSA issuance note commitments for V6 transactions
dmidem
force-pushed
the
zsa-integration-issuance-commitments
branch
from
4c6c101
to
714e631
Compare
… and refactor orchard_shielded_data_iter and orchard_shielded_data_field macros to use it" This reverts commit 2587b04.
…orchard_shielded_data macro from the reverted commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the
zebra-chaincrate to handle issuance action note commitments for V6 transactions.The main change merges note commitments from Orchard ZSA issuance actions with regular shielded data action note commitments in
Transaction::orchard_note_commitmentsmethod when an issuance is present in a V6 transaction.This integration allows for the automatic handling of issuance note commitments alongside shielded data commitments in other parts of the Zebra codebase, particularly within the note commitment Merkle tree in the
zebra_statecrate.V5 transactions remain unaffected, ensuring their existing behavior is preserved.