ZSA integration (step 5): Modify Orchard proptest implementations to support ZSA #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Introduced new type `Burn` that wraps `Vec<BurnItem>`, implemented serialization/deserialization for it - put it into `orchard_zsa/burn.rs`, also moved `NoBurn` there from `orchard_flavor_ext.rs` for better code structuring. 2. Renamed the `EncryptedNoteTest` trait to `TestArbitrary` in `orchard_flavor_ext.rs` and used it to constrain `BurnType` as well. 3. Renamed `serialize.rs` to `common.rs` in the `orchard_zsa` folder. 4. Refactored transaction generation strategies for V5 and V6 in `transaction/arbitrary.rs` and `orchard_zsa/arbitrary.rs` to incorporate the new burn handling and proper issuance handling.
dmidem
changed the title
dmidem
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the existing Orchard property-based test implementations to include transaction V6 ZSA fields (
burninShieldedDataandorchard_zsa_issue_data).Changes:
TestArbitrarytrait toorchard_flavor_extto conditionally modify the list of constraints forEncryptedNoteandBurnTypeassociated types.Arbitraryfororchard::ShieldedDataas a generic type.Burn, which wrapsVec<BurnItem>. Implemented serialization/deserialization for it and placed it inorchard_zsa/burn.rs. Also movedNoBurnthere fromorchard_flavor_ext.rsfor better code structuring.serialize.rstocommon.rsin theorchard_zsafolder.v5_strategyandv6_strategyfunctions intransaction/arbitrary.rsto work with V5 and V6 transactions, and to handle burn and issuance for V6.Note: This is draft code that needs to be cleaned up, possibly refactored/improved, and the FIXMEs resolved.