Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V6/Nu7 implementation #73

Merged
merged 85 commits into from
Oct 10, 2024
Merged

V6/Nu7 implementation #73

merged 85 commits into from
Oct 10, 2024

Commits on Jul 24, 2024

  1. minor update

    PaulLaux authored and alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    d58ac5b View commit details
    Browse the repository at this point in the history
  2. updated version

    PaulLaux authored and alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    f34dd02 View commit details
    Browse the repository at this point in the history
  3. commented out test code

    PaulLaux authored and alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    b890183 View commit details
    Browse the repository at this point in the history
  4. updated test and cleanup

    PaulLaux authored and alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    f62a230 View commit details
    Browse the repository at this point in the history
  5. New orchard version

    alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    a56c5da View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d670033 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c6175b8 View commit details
    Browse the repository at this point in the history
  8. updated Cargo.toml

    PaulLaux authored and alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    af4d4bb View commit details
    Browse the repository at this point in the history
  9. Fix post-rebase problems

    alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    fbbd655 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    424bf1a View commit details
    Browse the repository at this point in the history
  11. Make txid bytes public

    alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    b0b0f65 View commit details
    Browse the repository at this point in the history
  12. Note serialization

    alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    dac8d1f View commit details
    Browse the repository at this point in the history
  13. Update zcash_primitives to use the generalised version of orchard cra…

    …te (which supports Vanilla and ZSA) - but for now zcash_primitives is not generalised itself and pinned to Vanilla only
    dmidem authored and alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    cd8524b View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    3c83b72 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    aac4840 View commit details
    Browse the repository at this point in the history
  16. Fix post-rebase problems

    alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    6da0474 View commit details
    Browse the repository at this point in the history
  17. Note serialization

    alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    0049a3b View commit details
    Browse the repository at this point in the history
  18. Update zcash_primitives to use the generalised version of orchard cra…

    …te (which supports Vanilla and ZSA) - but for now zcash_primitives is not generalised itself and pinned to Vanilla only
    dmidem authored and alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    98f4747 View commit details
    Browse the repository at this point in the history
  19. Introduce issue bundle

    alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    2365c2b View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    7e87fa5 View commit details
    Browse the repository at this point in the history
  21. Work in progress

    alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    2bd5e45 View commit details
    Browse the repository at this point in the history
  22. Add ZSA

    alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    2704c8a View commit details
    Browse the repository at this point in the history
  23. Add issuance

    alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    5eec964 View commit details
    Browse the repository at this point in the history
  24. Fix fmt

    alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    3a18a4d View commit details
    Browse the repository at this point in the history
  25. Fix clippy

    alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    35f02fb View commit details
    Browse the repository at this point in the history
  26. Fix transparent-inputs

    alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    2ab8e16 View commit details
    Browse the repository at this point in the history
  27. Remove unproven enum

    alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    c841df1 View commit details
    Browse the repository at this point in the history
  28. Change methods visibility

    alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    fb2b73a View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    cdd8afa View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    5733e8d View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    008f35e View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    cbd3b38 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    307d025 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    ce0a391 View commit details
    Browse the repository at this point in the history
  35. Fix transparent builder

    alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    b7d4833 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    aad64db View commit details
    Browse the repository at this point in the history
  37. Fix formatting

    alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    c0d551d View commit details
    Browse the repository at this point in the history
  38. Fix clippy

    alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    944377d View commit details
    Browse the repository at this point in the history
  39. Fix merge issues

    alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    5856713 View commit details
    Browse the repository at this point in the history
  40. Adjust versions

    alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    9ddc1a7 View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    c0fbc44 View commit details
    Browse the repository at this point in the history
  42. Fix CI

    alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    1ffcf4e View commit details
    Browse the repository at this point in the history
  43. Fix tze build

    alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    beb1d8d View commit details
    Browse the repository at this point in the history
  44. Fix tze fmt

    alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    fee70aa View commit details
    Browse the repository at this point in the history
  45. Configuration menu
    Copy the full SHA
    2c11d9a View commit details
    Browse the repository at this point in the history
  46. Disable wasm target

    alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    918beb9 View commit details
    Browse the repository at this point in the history
  47. Configuration menu
    Copy the full SHA
    46ac12c View commit details
    Browse the repository at this point in the history
  48. Fix fmt

    alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    6b743b8 View commit details
    Browse the repository at this point in the history
  49. Update librustzcash to align with orchard crate (#67)

    This PR updates `librustzcash` to accommodate the recent refactoring
    changes in the `orchard` crate. The specific changes include:
    
    - Renamed all references from `orchard_flavors` to `orchard_flavor` to
    match the new module name.
    - Updated the `OrchardDomain` trait references to `OrchardDomainCommon`
    to reflect the trait renaming.
    - Adjusted the `Bundle` structure to use the fixed `NoteValue` type for
    the `burn` field, replacing the previous generic argument.
    - Refactored associated code to align with the new structure and naming
    conventions in the `orchard` crate.
    - Switched from the `orchardzsa-backward-compatibility-0.8.0-ak` to
    `orchardzsa-backward-compatibility-0.8.0` branch in `Cargo.toml` to use
    the latest version of the `orchard` crate.
    
    ---------
    
    Co-authored-by: Dmitry Demin <[email protected]>
    2 people authored and alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    9b9e525 View commit details
    Browse the repository at this point in the history
  50. Corrections to V7 transaction format and using updated test vectors (#66

    )
    
    This PR makes the following changes:
    - reordering of the component fields in `read_action` and `write_action`
    in issuance in order to make them spec compliant.
    - It sets some of the constant values for NU7 in a way that is
    consistent with the generated test vectors from the Python reference
    implementation (See QED-it/zcash-test-vectors#22
    for the changes to the Python reference implementation).
    - Some changes are made to function names to reflect the shift from
    preparing ZSAs for V7 rather than V6.
    - There are changes to the tests to use the `zcash_unstable` flag in
    order to cover both ZSA and vanilla Orchard behavior.
    - The test vectors are also expanded to include both the V5 vectors, and
    the V7 vectors (behind a `zcash_unstable` flag).
    vivek-arte authored and alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    cac470f View commit details
    Browse the repository at this point in the history
  51. Remove duplicate import

    alexeykoren committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    f160f25 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Reformat feature flag

    alexeykoren committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    4dbee84 View commit details
    Browse the repository at this point in the history
  2. Address PR comments

    alexeykoren committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    8b9672d View commit details
    Browse the repository at this point in the history
  3. Address PR comments

    alexeykoren committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    1860f1d View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Fmt

    alexeykoren committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    f4cf872 View commit details
    Browse the repository at this point in the history
  2. Clippy

    alexeykoren committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    aec1879 View commit details
    Browse the repository at this point in the history
  3. Use ZSA BundleType

    alexeykoren committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    830260f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    acb8f97 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4f6ec46 View commit details
    Browse the repository at this point in the history
  6. Fmt

    alexeykoren committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    3d20879 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Add finalization

    alexeykoren committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    7f045e7 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Configuration menu
    Copy the full SHA
    f411948 View commit details
    Browse the repository at this point in the history
  2. Fmt

    alexeykoren committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    3ac2618 View commit details
    Browse the repository at this point in the history
  3. Fix double import

    alexeykoren committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    ea1770e View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Use updated zsa1

    alexeykoren committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    fe88163 View commit details
    Browse the repository at this point in the history
  2. Fmt

    alexeykoren committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    fc38730 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Update zcash_primitives to sync with latest sapling-crypto changes (#70)

    This PR updates the `zcash_primitives` crate to align with the recent
    changes in the `sapling-crypto` crate, which was updated to sync with
    the latest changes in `zcash_note_encryption`.
    
    ### Changes:
    - Updated the usage of `enc_ciphertext` to call `.as_ref()` to match the
    new return type.
    - Adjusted the import of the `ENC_CIPHERTEXT_SIZE` constant to use the
    definition from `sapling-crypto` instead of `zcash_note_encryption`, as
    the constant has been moved to `sapling-crypto`.
    
    Co-authored-by: Dmitry Demin <[email protected]>
    dmidem and dmidem authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    6652222 View commit details
    Browse the repository at this point in the history
  2. Minor changes

    alexeykoren committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    dc0a815 View commit details
    Browse the repository at this point in the history
  3. Change V7 to v6

    alexeykoren committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    a434849 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9f52b1b View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Updated test vectors (#71)

    This updates the test vectors to be of version 6 (as opposed to
    version 7).
    
    It also provides a new file for the V6 test vectors, an improvement to
    having them in the same file but behind feature flags.
    
    It provides a error for when the asset description string is not a UTF8
    encoding.
    vivek-arte authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    10ff1e0 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. PR fixes

    alexeykoren committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    f79962b View commit details
    Browse the repository at this point in the history
  2. PR fixes

    alexeykoren committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    738ed17 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Uncomment CI

    alexeykoren committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    25c6cd1 View commit details
    Browse the repository at this point in the history
  2. Add PR fixes

    alexeykoren committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    655d961 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. PR Fixes

    alexeykoren committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    fc12237 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8a40922 View commit details
    Browse the repository at this point in the history
  3. Add tx building to tests

    alexeykoren committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    12a39c2 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Add test for burn

    alexeykoren committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    9c51a46 View commit details
    Browse the repository at this point in the history
  2. Fmt

    alexeykoren committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    6283d33 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    75e3b46 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4101a96 View commit details
    Browse the repository at this point in the history
  5. Simplify imports

    alexeykoren committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    a0a7d38 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. PR fixes

    alexeykoren committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    b2d7b18 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. updated syntax

    PaulLaux committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    798630a View commit details
    Browse the repository at this point in the history