WIP Issue #29 - Add batch capability for running analytics over historical results (e.g. after uploading data from SD cards) #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… over historical results (e.g. after uploading data from SD cards)
… over historical results (e.g. after uploading data from SD cards)
krook
changed the title
upkarlidder
reviewed
Mar 31, 2021
src/core_decision_flask_app.py
Outdated
| # Return 404 (Not Found) if the record IDs are invalid | ||
| if (date is None) : | ||
| logger.error('Missing parameters : '+DATE_PARAMETER+' : '+str(date)) | ||
| abort(404) |
There was a problem hiding this comment.
Comment - @Gaurav-Ramakrishna @upkarlidder
Should this error be
- 400 - bad request (@Gaurav-Ramakrishna says this)
- 422 - Unprocessable Entity
FYI @JSegrave-IBM
upkarlidder
reviewed
Mar 31, 2021
src/core_decision_flask_app.py
Outdated
| def batch_run_analytics_by_date(): | ||
|
|
||
| try: | ||
| date = request.args.get(DATE_PARAMETER) |
There was a problem hiding this comment.
@JSegrave-IBM should we validate the date here? We just check for None.
upkarlidder
reviewed
Mar 31, 2021
There was a problem hiding this comment.
@JSegrave-IBM added some comments.
Can we also write a unit test or something to test it out before pushing it into master?
…e-checking and 400 return code.
… records in the batch window (also refactored batch_run_analytics to be a little clearer - it takes a start & end time now (rather than a schedule of individual minutes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #29 - Add batch capability for running analytics over historical results (e.g. after uploading data from SD cards)