PR #11 - Issue 117 - analytics updated to handle maxed out sensors #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l value rather than a PPM for sensor readings, TWAs and Gauge values affected. See issue 117 for details.
… exceeded their range. This change makes sure the analytics handle that signal value correctly and updates the test data to reflect what the sensors are expected to send. Also standardised the use of pandas .loc selectors.
upkarlidder
approved these changes
Oct 12, 2020
upkarlidder
approved these changes
Oct 12, 2020
upkarlidder
approved these changes
Oct 12, 2020
upkarlidder
approved these changes
Oct 12, 2020
narengan
approved these changes
Oct 12, 2020
|
@lidderupk @narengan - thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Call-for-Code/Prometeo-Pyrrha#117
This PR covers the analytics side of issue 117. The firmware side is still required for the issue to be fully resolved.