Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding View 리팩토링 #152

Merged
merged 6 commits into from
Jun 21, 2024
Merged

Onboarding View 리팩토링 #152

merged 6 commits into from
Jun 21, 2024

Conversation

WhiteHyun
Copy link
Member

Screenshots 📸

Before After
RPReplay_Final1718886172 Simulator Screen Recording - iPhone 15 Pro - 2024-06-21 at 12 12 38



고민, 과정, 근거 💬

  • design에 맞지 않는 레이아웃 수정
  • TabView 대신 ScrollView로 구현
  • Int타입의 currentPage를 UUID타입의 activeID로 변경하여 현재 보이는 온보딩 페이지의 값을 처리함



References 📋




@WhiteHyun WhiteHyun added 🔧 Enhancement Improvement or Feedback Implementation 🚀 Onboarding Onboarding View labels Jun 21, 2024
@WhiteHyun WhiteHyun added this to the v2.0.1 milestone Jun 21, 2024
@WhiteHyun WhiteHyun self-assigned this Jun 21, 2024
@WhiteHyun WhiteHyun linked an issue Jun 21, 2024 that may be closed by this pull request
2 tasks
@WhiteHyun WhiteHyun merged commit ea58c11 into main Jun 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 Enhancement Improvement or Feedback Implementation 🚀 Onboarding Onboarding View
Projects
Development

Successfully merging this pull request may close these issues.

[Feat]: 온보딩뷰 리팩토링
1 participant