Network 모듈 이름을 NetworkAPIKit으로 변경 / 네트워크 장애 또는 안정화 시 토스트 알림 / Script 동작 조건 수정 #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhiteHyun
added
🔧 Enhancement
1 task
|
너무 안 보여서 색상을 역전시켰습니다! |
WhiteHyun
changed the title
eung7
previously approved these changes
Mar 25, 2024
|
방금 구현하신 것도 마음에 드네요!!! ㅎㅎㅎ |
|
편행 메인 색으로 바꿔봤는데 어떠신가요? 저는 방금 바꾼 편행색이 제일 마음에 드는 것 같아요 ㅋㅋ 가독성도 훨 좋고요!
|
|
네! 훨씬 좋은 것 같아요 !! 수고하셨습니다 ㅎㅎ |
…ency and branding purposes.
eung7
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots 📸
고민, 과정, 근거 💬
Renamed 📝
import Network를 해야했으나, 이미 제가 따로 Network모듈을 만들어놔서 불가피하게 이름을 변경해야 했습니다.Feature ✨
그리고 Network Monitor를 사용하여 기기의 네트워킹 정보를 전용 큐에서 계속 확인할 수 있도록 구현해두었습니다.
최상단 App에서
onReceive(_:)를 사용해서 데이터가 변경될 때마다 Toast를 띄우도록 했어요.Swiftformat, swiftlint 동작 조건을 수정했습니다. 기존에는 Debug모드일 때 동작하도록 구현해두었는데,
Staging이 생겨서 해당 조건식을 삭제하는 게 낫겠더라고요. :)