Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed Attachment Metadata Being Set Incorrectly In Interaction Responses #2679

Merged
merged 6 commits into from
Dec 28, 2024
Merged

fix: Fixed Attachment Metadata Being Set Incorrectly In Interaction Responses #2679

merged 6 commits into from
Dec 28, 2024

Conversation

Icebluewolf
Copy link
Contributor

Summary

In interaction responses attachment metadata was being placed in the wrong spot in the request body causing discord to ignore it.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Icebluewolf Icebluewolf requested a review from a team as a code owner December 27, 2024 00:42
@pullapprove4 pullapprove4 bot requested a review from VincentRPS December 27, 2024 00:42
@plun1331 plun1331 added bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer labels Dec 27, 2024
plun1331
plun1331 previously approved these changes Dec 27, 2024
View reviewed changes
@plun1331 plun1331 enabled auto-merge (squash) December 27, 2024 08:29
JustaSqu1d
JustaSqu1d suggested changes Dec 27, 2024
View reviewed changes
Copy link
Member

@JustaSqu1d JustaSqu1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slightly ambiguous wording fix

CHANGELOG.md Outdated Show resolved Hide resolved
Dorukyum
Dorukyum previously approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording is fine

@JustaSqu1d
Copy link
Member

The wording is fine

It could be interpreted as the "interaction responses" being ignored as opposed to the "attachment metadata"

@Dorukyum
Copy link
Member

The wording is fine

It could be interpreted as the "interaction responses" being ignored as opposed to the "attachment metadata"

I hadn't realised that but your suggestion wouldn't solve it

auto-merge was automatically disabled December 27, 2024 17:08

Head branch was pushed to by a user without write access

@Icebluewolf Icebluewolf dismissed stale reviews from Dorukyum and plun1331 via 4fcb515 December 27, 2024 17:08
@Icebluewolf Icebluewolf mentioned this pull request Dec 28, 2024
Closed
3 tasks
@Icebluewolf
Copy link
Contributor Author

Don't merge yet

Dorukyum
Dorukyum requested changes Dec 28, 2024
View reviewed changes
discord/webhook/async_.py Outdated Show resolved Hide resolved
@Icebluewolf
Copy link
Contributor Author

Should Be Fixed
I tested

  • Defer + Message
  • Defer + Message With Attachment
  • Message
  • Message With Attachment

@Dorukyum Dorukyum force-pushed the interaction_attachment_metadata branch from 2f3ab42 to 88503b7 Compare December 28, 2024 20:10
@Dorukyum Dorukyum enabled auto-merge (squash) December 28, 2024 20:12
@Dorukyum
chore: use inline if
88503b7 
Signed-off-by: Dorukyum <[email protected]>
Lulalaby
Lulalaby approved these changes Dec 28, 2024
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that looks better lmao

@Lulalaby Lulalaby requested a review from JustaSqu1d December 28, 2024 20:29
@Dorukyum Dorukyum merged commit b4b2bdb into Pycord-Development:master Dec 28, 2024
25 checks passed
@Icebluewolf Icebluewolf deleted the interaction_attachment_metadata branch December 29, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

@plun1331 plun1331 plun1331 left review comments

@VincentRPS VincentRPS Awaiting requested review from VincentRPS

@JustaSqu1d JustaSqu1d Awaiting requested review from JustaSqu1d

Assignees
No one assigned
Labels
bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Icebluewolf @JustaSqu1d @Dorukyum @Lulalaby @plun1331