Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ Add missing soundboard and monetization permissions #2620

Merged

Conversation

Paillat-dev
Copy link
Contributor

@Paillat-dev Paillat-dev commented Oct 24, 2024

Summary

Information

  • This PR fixes an issue.
    partially fixes but not entirely Soundboard #2216
    Note: permissions were not part of feat: implement soundboard features #2321 (now closed), this is additional to that or other pr
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Paillat-dev Paillat-dev requested a review from a team as a code owner October 24, 2024 11:20
@pullapprove4 pullapprove4 bot requested a review from FrostByte266 October 24, 2024 11:20
@Paillat-dev Paillat-dev changed the title ✨ Soundboard perms (1 << 42) feat: ✨ Soundboard perms (1 << 42) Oct 24, 2024
@Paillat-dev Paillat-dev force-pushed the soundboard-permissions branch from 6be9354 to 203b9c7 Compare October 24, 2024 11:30
@Paillat-dev
Copy link
Contributor Author

This:

@bot.slash_command()
async def toggle_soundboard_perms_false(ctx: discord.ApplicationContext, channel: discord.VoiceChannel):
    await channel.edit(overwrites={ctx.guild.default_role: discord.PermissionOverwrite(use_soundboard=False)})
    await ctx.respond(f"Soundboard perms for {channel} have been toggled off.")


@bot.slash_command()
async def toggle_soundboard_perms_true(ctx: discord.ApplicationContext, channel: discord.VoiceChannel):
    await channel.edit(overwrites={ctx.guild.default_role: discord.PermissionOverwrite(use_soundboard=True)})

    await ctx.respond(f"Soundboard perms for {channel} have been toggled on.")

@bot.slash_command()
async def toggle_soundboard_perms_default(ctx: discord.ApplicationContext, channel: discord.VoiceChannel):
    await channel.edit(overwrites={ctx.guild.default_role: discord.PermissionOverwrite(use_soundboard=None)})

    await ctx.respond(f"Soundboard perms for {channel} have been reset to default.")

CHANGELOG.md Outdated Show resolved Hide resolved
@JustaSqu1d
Copy link
Member

JustaSqu1d commented Oct 24, 2024

Might as well also add USE_EXTERNAL_SOUNDS(1 << 45)

@Paillat-dev Paillat-dev changed the title feat: ✨ Soundboard perms (1 << 42) feat: ✨ Soundboard perms (1 << 42, 1 << 45) Oct 24, 2024
@Paillat-dev Paillat-dev force-pushed the soundboard-permissions branch 2 times, most recently from e1f1aea to 588aa97 Compare October 24, 2024 13:05
@Paillat-dev Paillat-dev force-pushed the soundboard-permissions branch from 588aa97 to 5b2f1ae Compare October 24, 2024 13:58
@Paillat-dev Paillat-dev changed the title feat: ✨ Soundboard perms (1 << 42, 1 << 45) feat: ✨ Add missing permissions (soundboard + subscriptions thing analythics whatever) Oct 24, 2024
@Paillat-dev Paillat-dev changed the title feat: ✨ Add missing permissions (soundboard + subscriptions thing analythics whatever) feat: ✨ Add missing permissions (soundboard + subscriptions thing analytics whatever) Oct 24, 2024
@Paillat-dev Paillat-dev force-pushed the soundboard-permissions branch from 5b2f1ae to 9202002 Compare October 24, 2024 14:01
discord/permissions.py Show resolved Hide resolved
Lulalaby
Lulalaby previously approved these changes Oct 24, 2024
@Paillat-dev
Copy link
Contributor Author

Paillat-dev commented Oct 24, 2024

Pls don't merge yet

discord/permissions.py Outdated Show resolved Hide resolved
auto-merge was automatically disabled October 29, 2024 09:53

Head branch was pushed to by a user without write access

@Paillat-dev Paillat-dev force-pushed the soundboard-permissions branch from b15e852 to 3bd902a Compare October 29, 2024 09:53
plun1331
plun1331 previously approved these changes Nov 2, 2024
@plun1331 plun1331 enabled auto-merge (squash) November 2, 2024 20:26
@Dorukyum Dorukyum changed the title feat: ✨ Add missing permissions (soundboard + subscriptions thing analytics whatever) feat: ✨ Add missing soundboard and monetization permissions Nov 3, 2024
Signed-off-by: Dorukyum <[email protected]>
Dorukyum
Dorukyum previously approved these changes Nov 3, 2024
Signed-off-by: Dorukyum <[email protected]>
@plun1331 plun1331 requested a review from JustaSqu1d November 3, 2024 15:55
@Dorukyum Dorukyum merged commit 968a586 into Pycord-Development:master Nov 3, 2024
25 checks passed
@Paillat-dev Paillat-dev deleted the soundboard-permissions branch November 3, 2024 16:00
OmLanke pushed a commit to OmLanke/pycord that referenced this pull request Dec 16, 2024
…evelopment#2620)

* ✨ Soundboard perms (`1 << 42`, `1 << 45`)

* ✨ Add creator monetization analytics perms (`1 << 41`)

* 📝 CHANGELOG.md

* Update CHANGELOG.md

Signed-off-by: Dorukyum <[email protected]>

---------

Signed-off-by: Dorukyum <[email protected]>
Co-authored-by: plun1331 <[email protected]>
Co-authored-by: Dorukyum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Implements a feature priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants