Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove {ll} wildcard and replace with config setting #1472

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

fneum
Copy link
Member

@fneum fneum commented Dec 30, 2024

Closes #1354.

Changes proposed in this Pull Request

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

Copy link
Contributor

github-actions bot commented Dec 30, 2024

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

❗ Run failed!

Download 'logs' artifact to see more details.

  • master failed in: make_summary
  • remove-ll-wc failed in: add_electricity, add_electricity, add_electricity

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing remove-ll-wc (289de68) with master (cf1eb86).
Branch is 9 commits ahead and 0 commits behind.
Last updated on 2025-01-03 14:29:59 CET.

@fneum fneum marked this pull request as ready for review January 3, 2025 11:18
@fneum fneum requested a review from FabianHofmann as a code owner January 3, 2025 11:18
@fneum fneum mentioned this pull request Jan 3, 2025
@fneum fneum requested a review from lisazeyen as a code owner January 3, 2025 11:56
@fneum fneum added this to the v0.14.0 milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove {ll} wildcard?
1 participant