Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test build shapes and minor changes to test_base_network.py #1466

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

finozzifa
Copy link
Collaborator

@finozzifa finozzifa commented Dec 19, 2024

Closes # (if applicable).

Changes proposed in this Pull Request

The pull request proposes the following unit tests:

test/test_build_shapes.py:

  • test_simplify_polys
  • test_countries

conftest.py:

  • I added the italy_shape fixture. It replaces the test/test_data/italy_shape.geojson file (which in fact has been deleted).

test/test_base_network.py:

  • I replaced italy_shape.geojson with the fixture italy_shape

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

@finozzifa finozzifa changed the title Unit test build shapes Unit test build shapes and minor changes to test_base_network.py Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant