Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to OSM-prebuilt v0.6 #1431

Merged
merged 38 commits into from
Dec 2, 2024
Merged

Update to OSM-prebuilt v0.6 #1431

merged 38 commits into from
Dec 2, 2024

Conversation

bobbyxng
Copy link
Contributor

@bobbyxng bobbyxng commented Nov 19, 2024

Closes # (if applicable).

Changes proposed in this Pull Request

  • Added interactive map to the Zenodo databundle: https://zenodo.org/records/14144752
  • Can be directly accessed through: https://pypsa-eur.readthedocs.io/en/latest/data-base-network.html Thanks @lkstrp
  • Prebuilt network includes all technical parameters (impedance, nominal current, reactance, susceptance, etc.) for potential use outside PyPSA/PyPSA-Eur
  • Scripts build_osm_network and prepare_osm_network_release reflect this change and include the construction of the interactive map. Base network and subsequent steps are not impacted by this.
  • I have tested the model at hourly resolution for the target year, model converges, results are similar to the gridkit-based network.

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

bobbyxng and others added 30 commits October 14, 2024 19:56
…eating voltage-specific bus endings in stations.
@bobbyxng bobbyxng requested a review from lisazeyen November 19, 2024 14:16
@bobbyxng bobbyxng self-assigned this Nov 19, 2024
Copy link
Contributor

github-actions bot commented Nov 19, 2024

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

General

Plots comparison
Main branch Feature branch
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Files comparison
Status NRMSE MAE (norm)

NRMSE: Normalized (combined-min-max) Root Mean Square Error
MAE (norm): Mean Absolute Error on normalized data (min-max)
Status Threshold: MAE (norm) > 0.05 and NRMSE > 0.3

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing osm-prebuilt-0.6 (8b68b93) with master (98d387c).
Branch is 38 commits ahead and 1 commits behind.
Last updated on 2024-11-21 13:08:52 CET.

@fneum fneum merged commit 920ffb4 into master Dec 2, 2024
12 checks passed
@FabianHofmann
Copy link
Contributor

@bobbyxng I have problems with the retrieval of map.html. they are not included in the zenodo repo. Is that perhaps something for future zenodo versions?

@bobbyxng
Copy link
Contributor Author

@bobbyxng I have problems with the retrieval of map.html. they are not included in the zenodo repo. Is that perhaps something for future zenodo versions?

Hi @FabianHofmann ! I just did a test using the latest pypsa-eur master branch, for me map.htmlis downloaded just like all other files. Note the file only exists from version 0.6 onwards. Download takes a bit longer (in my case around 30 seconds), as it's quite large at >40 MB

@FabianHofmann
Copy link
Contributor

Gotcha! thanks, I still had the old version!

@FabianHofmann
Copy link
Contributor

on the other hand this means that the osm version setting is obsolete. At least setting version <0.6, which the current code suggests to be working, breaks. I would suggest to either only support version tags >= 0.6 or make the code flexible to support also older versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants