Keep existing conventional generation in sector network #1366

martacki · 2024-10-16T09:26:53Z

Closes # (if applicable).

Changes proposed in this Pull Request

The sector coupled network currently removes existing conventional generators. This PR adds them back (in the traditional sectoral setup with EU Generators + Links)

Checklist

I tested my contribution locally and it works as intended.
Code and workflow changes are sufficiently documented.
Changed dependencies are added to envs/environment.yaml.
Changes in configuration options are added in config/config.default.yaml.
Changes in configuration options are documented in doc/configtables/*.csv.
Sources of newly added data are documented in doc/data_sources.rst.
A release note doc/release_notes.rst is added.

for more information, see https://pre-commit.ci

github-actions · 2024-10-16T10:44:38Z

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

General

Plots comparison

Main branch	Feature branch

Files comparison

	Status	NRMSE	MAE (norm)
weighted_prices.csv	⚠️Changed	0.514	0.50
price_statistics.csv	⚠️Changed	0.001	0.21
metrics.csv	⚠️Changed	0.000	0.06
nodal_cfs.csv	⚠️ NaN mismatch
nodal_supply_energy.csv	⚠️ NaN mismatch
nodal_capacities.csv	⚠️ NaN mismatch
prices.csv	⚠️ NaN mismatch
supply.csv	⚠️ NaN mismatch
nodal_costs.csv	⚠️ NaN mismatch
market_values.csv	⚠️ NaN mismatch
capacities.csv	⚠️ NaN mismatch
curtailment.csv	⚠️ NaN mismatch
costs.csv	⚠️ NaN mismatch
cfs.csv	⚠️ NaN mismatch
supply_energy.csv	⚠️ NaN mismatch
energy.csv	⚠️ NaN mismatch

NRMSE: Normalized (combined-min-max) Root Mean Square Error
MAE (norm): Mean Absolute Error on normalized data (min-max)
Status Threshold: MAE (norm) > 0.05 and NRMSE > 0.3

Model Metrics

Benchmarks

Comparing keep_conventionals_in_sector (37c6093) with master (52b8179).
Branch is 8 commits ahead and 0 commits behind.
Last updated on 2024-11-05 11:03:42 CET.

martacki · 2024-10-16T13:32:25Z

Except for typos (my specialty), there seems to be only the same bug as in master, which is why Windows OS is failing (nut sure about why).

Remaining discussion points could be:

I designed the same setup for nuclear as for fossil generation (Generator uranium connected with a nuclear link). I think that makes more sense, currently it simply remained a "nuclear generator", but this was a bit confusing
Currently, if existing capacities are kept and the carrier is expandable, only the existing locations can be expanded. The same carrier can not be expanded at a different site, if that site has no existing capacity. Could be potentially fixed, but wasn't needed in our case

Otherwise, seems to work.
Nuclear / coal generation in power only model:

Nuclear/coal generation at sectoral model:

Sectoral model dispatch (in links_t.p1) (Co2L0.5 for whole EU, 121H, 59 clusters)
nuclear

coal

default config settings don't change the current default output (except that nuclear is not kept anymore in the generators)

tgilon · 2024-11-28T15:38:23Z

scripts/prepare_sector_network.py

+    fossils = ["coal", "gas", "oil", "lignite", "uranium"]
    if options["fossil_fuels"] and carrier in fossils:


Suggested change

fossils = ["coal", "gas", "oil", "lignite", "uranium"]

if options["fossil_fuels"] and carrier in fossils:

fossils = ["coal", "gas", "oil", "lignite"]

if (options["fossil_fuels"] and carrier in fossils) or (carrier == "uranium"):

As uranium is not a fossil fuel, this would be less misleading.

@daniel-rdt

tgilon · 2024-11-28T17:02:03Z

scripts/prepare_sector_network.py

+            p_max_pu=(
+                0.7 if carrier == "uranium" else 1
+            ),  # be conservative for nuclear (maintenance or unplanned shut downs)


For consistency, it would be good to use this value in add_existing_baseyearas well.

pypsa-eur/scripts/add_existing_baseyear.py

Lines 319 to 337 in 728eacf

if generator != "urban central solid biomass CHP":

n.add(

"Link",

new_capacity.index,

suffix=name_suffix,

bus0=bus0,

bus1=new_capacity.index,

bus2="co2 atmosphere",

carrier=generator,

marginal_cost=costs.at[generator, "efficiency"]

* costs.at[generator, "VOM"], # NB: VOM is per MWel

capital_cost=costs.at[generator, "efficiency"]

* costs.at[generator, "fixed"], # NB: fixed cost is per MWel

p_nom=new_capacity / costs.at[generator, "efficiency"],

efficiency=costs.at[generator, "efficiency"],

efficiency2=costs.at[carrier[generator], "CO2 intensity"],

build_year=grouping_year,

lifetime=lifetime_assets.loc[new_capacity.index],

)

It would be even better to use the country specific values from data/nuclear_p_max_pu.csv.

@daniel-rdt

daniel-rdt · 2024-11-29T17:50:54Z

scripts/prepare_sector_network.py

@@ -4538,6 +4590,17 @@ def add_enhanced_geothermal(n, egs_potentials, egs_overlap, costs):
    )
    pop_weighted_energy_totals.update(pop_weighted_heat_totals)

+    if options.get("keep_existing_capacities", False):


Suggested change

if options.get("keep_existing_capacities", False):

if options.get("keep_existing_capacities", False) and snakemake.params.foresight not in ["myopic", "perfect"]:

It would make sense to limit this functionality to overnight, as for myopic and perfect optimization existing caps are added later on. fyi @martacki

daniel-rdt · 2024-11-29T17:51:26Z

scripts/prepare_sector_network.py

@@ -4551,7 +4614,7 @@ def add_enhanced_geothermal(n, egs_potentials, egs_overlap, costs):

    spatial = define_spatial(pop_layout.index, options)

-    if snakemake.params.foresight in ["myopic", "perfect"]:
+    if snakemake.params.foresight in ["overnight", "myopic", "perfect"]:


Are these not all the cases, i.e. we could leave the if condition out completely now?

martacki and others added 4 commits October 16, 2024 11:12

keep existing conventionals in sector network

3fd2e51

Merge branch 'master' into keep_conventionals_in_sector

4b26289

[pre-commit.ci] auto fixes from pre-commit.com hooks

57985c1

for more information, see https://pre-commit.ci

release_notes and configtables

a6eb47f

martacki added 4 commits October 18, 2024 14:37

fix typos

03aa47d

Merge branch 'master' into keep_conventionals_in_sector

28ff2f8

Merge branch 'master' into keep_conventionals_in_sector

4adc3bd

Merge branch 'master' into keep_conventionals_in_sector

37c6093

tgilon reviewed Nov 28, 2024

View reviewed changes

daniel-rdt reviewed Nov 29, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Keep existing conventional generation in sector network #1366

Keep existing conventional generation in sector network #1366

martacki commented Oct 16, 2024 •

edited

Loading

github-actions bot commented Oct 16, 2024 •

edited

Loading

martacki commented Oct 16, 2024 •

edited

Loading

tgilon Nov 28, 2024

tgilon Nov 28, 2024

tgilon Nov 28, 2024

daniel-rdt Nov 29, 2024 •

edited

Loading

daniel-rdt Nov 29, 2024

		fossils = ["coal", "gas", "oil", "lignite", "uranium"]
		if options["fossil_fuels"] and carrier in fossils:

	if generator != "urban central solid biomass CHP":
	n.add(
	"Link",
	new_capacity.index,
	suffix=name_suffix,
	bus0=bus0,
	bus1=new_capacity.index,
	bus2="co2 atmosphere",
	carrier=generator,
	marginal_cost=costs.at[generator, "efficiency"]
	* costs.at[generator, "VOM"], # NB: VOM is per MWel
	capital_cost=costs.at[generator, "efficiency"]
	* costs.at[generator, "fixed"], # NB: fixed cost is per MWel
	p_nom=new_capacity / costs.at[generator, "efficiency"],
	efficiency=costs.at[generator, "efficiency"],
	efficiency2=costs.at[carrier[generator], "CO2 intensity"],
	build_year=grouping_year,
	lifetime=lifetime_assets.loc[new_capacity.index],
	)

	if options.get("keep_existing_capacities", False):
	if options.get("keep_existing_capacities", False) and snakemake.params.foresight not in ["myopic", "perfect"]:

Keep existing conventional generation in sector network #1366

Are you sure you want to change the base?

Keep existing conventional generation in sector network #1366

Conversation

martacki commented Oct 16, 2024 • edited Loading

Changes proposed in this Pull Request

Checklist

github-actions bot commented Oct 16, 2024 • edited Loading

Validator Report

martacki commented Oct 16, 2024 • edited Loading

tgilon Nov 28, 2024

Choose a reason for hiding this comment

tgilon Nov 28, 2024

Choose a reason for hiding this comment

tgilon Nov 28, 2024

Choose a reason for hiding this comment

daniel-rdt Nov 29, 2024 • edited Loading

Choose a reason for hiding this comment

daniel-rdt Nov 29, 2024

Choose a reason for hiding this comment

martacki commented Oct 16, 2024 •

edited

Loading

github-actions bot commented Oct 16, 2024 •

edited

Loading

martacki commented Oct 16, 2024 •

edited

Loading

daniel-rdt Nov 29, 2024 •

edited

Loading