Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NUTS3 shapes #1286

Merged
merged 6 commits into from
Sep 12, 2024
Merged

Update NUTS3 shapes #1286

merged 6 commits into from
Sep 12, 2024

Conversation

cpschau
Copy link
Contributor

@cpschau cpschau commented Sep 12, 2024

Closes #1242

Changes proposed in this Pull Request

The NUTS3 and NUTS2 shapes have been updated from a 1:60M resolution (red) to a more detailed 1:3M resolution (blue). The data is now directly retrieved from GISCO, making the previously used resources, which are part of the data bundle hosted on Zenodo, redundant and removable.

Screenshot from 2024-08-28 16-31-20
Screenshot from 2024-08-28 16-29-26
Screenshot from 2024-08-28 16-28-40

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "nuts/NUTS_RG_10M_2013_4326_LEVL_2.geojson" (which is currently in the data bundle) actually also included in the downloaded ZIP? Then one could include it here as well and remove from the data bundle.

Then they could both be extracted into data/nuts

rules/retrieve.smk Outdated Show resolved Hide resolved
rules/retrieve.smk Outdated Show resolved Hide resolved
@cpschau
Copy link
Contributor Author

cpschau commented Sep 12, 2024

Is "nuts/NUTS_RG_10M_2013_4326_LEVL_2.geojson" (which is currently in the data bundle) actually also included in the downloaded ZIP? Then one could include it here as well and remove from the data bundle.

Then they could both be extracted into data/nuts

The NUTS_RG_03M_2013_4326_LEVL_2.geojson with (also with 1:3M not 1:10M) is included and could be co-retrieved.

@cpschau cpschau requested a review from fneum September 12, 2024 15:47
Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@fneum fneum merged commit e35f651 into master Sep 12, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants