Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cooling demand #415

Merged
merged 7 commits into from
Jan 2, 2025
Merged

Add cooling demand #415

merged 7 commits into from
Jan 2, 2025

Conversation

ekatef
Copy link
Contributor

@ekatef ekatef commented Dec 3, 2024

Changes proposed in this Pull Request

The PR adds implementation of cooling demand similarly as it's done for heating

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Unit tests for new features were added (if applicable).
  • Newly introduced dependencies are added to environment.yaml, environment_docs.yaml and setup.py (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the MIT license.

Copy link
Member

@lkstrp lkstrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if we don't touch general things, but method wise I would like to ping someone who is more into atlite.

@lkstrp lkstrp assigned lkstrp and unassigned lkstrp Dec 4, 2024
@lkstrp lkstrp requested a review from euronion December 4, 2024 11:21
@ekatef
Copy link
Contributor Author

ekatef commented Dec 4, 2024

Looks good to me if we don't touch general things, but method wise I would like to ping someone who is more into atlite.

Thanks for the quick response and coordination @lkstrp! 😄

Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One thing you could clarify is how the 23°C default threshold was chosen, but it's a very minor comment.

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci
@ekatef
Copy link
Contributor Author

ekatef commented Dec 30, 2024

LGTM! One thing you could clarify is how the 23°C default threshold was chosen, but it's a very minor comment.

@fneum thanks a lot for looking into that! Have added a short comment on that to the docstring.

Adding a bit more details here to facilitate tracking the things, as a default threshold can be quite important, especially for the regions where the warm season temperatures are around the threshold.

Currently, there is no globally-accepted standard for CDD definitions. For US, EIA recommends 65F = 18.3C, while for Europe the official definitions are more liberal, like 22C by UK Met Office and by Umweltbundesamt, and 24C by European Commission.

@fneum fneum merged commit a0ff669 into PyPSA:master Jan 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants