-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cooling demand #415
Add cooling demand #415
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me if we don't touch general things, but method wise I would like to ping someone who is more into atlite
.
Thanks for the quick response and coordination @lkstrp! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One thing you could clarify is how the 23°C default threshold was chosen, but it's a very minor comment.
[pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
@fneum thanks a lot for looking into that! Have added a short comment on that to the docstring. Adding a bit more details here to facilitate tracking the things, as a default threshold can be quite important, especially for the regions where the warm season temperatures are around the threshold. Currently, there is no globally-accepted standard for CDD definitions. For US, EIA recommends 65F = 18.3C, while for Europe the official definitions are more liberal, like 22C by UK Met Office and by Umweltbundesamt, and 24C by European Commission. |
Changes proposed in this Pull Request
The PR adds implementation of cooling demand similarly as it's done for heating
Checklist
doc
.environment.yaml
,environment_docs.yaml
andsetup.py
(if applicable).doc/release_notes.rst
of the upcoming release is included.