Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #212
Touches #211
Change proposed in this Pull Request
Initial attempt was to solve #211, but is turns out to be tricky. The problem is that the era5 module relies on get_ functions which take the era5 retrieval parameters as an argument. The SolarPosition function however requires a dataset with the complete set of coordinates. It would be necessary to pass the
cutout.data
as an argument to theget_solar_position
function. This requires changes one have to think through a bit.The same counts for the sarah module. Its
get_data
function does not use thefeature
argument so far. It would be necessary to make separateget_influx
andget_solar_position
functions. I would postpone that change to another time.In order to make the
influx
feature still a bit handier, I removed the solar athmospheric insolation variable from theinflux
feature as well as from theSolarPosition
function. The variables were renamed tosolar_azimuth
andsolar_altitude
.Motivation and Context
Make the
influx
feature leaner. Make data variables accessible viacutout.data.solar_altitude
/cutout.data.solar_azimuth
How Has This Been Tested?
No test added.
Type of change
Checklist
pytest
inside the repository and no unexpected problems came up.doc/
.environment.yaml
file.doc/release_notes.rst
.pre-commit run --all
to lint/format/check my contribution