-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
removed pipe on stdin and stderr to leave only stdout, this seems to be fine now
- Loading branch information
Showing
2 changed files
with
6 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ef15fc9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering what is the reason for using
shell=True
? It's causing problems for me (PyMoDaq 4.1.1, Arch Linux). Specifically, the line where itreadline()
thestdout
, it opens up a shell in the terminal from which I launched the plugin manager and waits for my input. Closing that shell (Ctrl+D) makes the program continue without ever installing the package.Removing the
shell=True
makes it possible to install the plugins, at least on my system.