Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace 'counter' function with 'collection.Counter' #814

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Replace 'counter' function with 'collection.Counter' #814

merged 4 commits into from
Jun 28, 2024
+2 −13

Conversation

edreamleo
Copy link
Contributor

See #813.

@edreamleo edreamleo changed the title PR: Replace 'counter' function with 'collection.Counter'. All tests pass PR: Replace 'counter' function with 'collection.Counter' Jun 25, 2024
asottile
asottile reviewed Jun 25, 2024
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove "PR:" from your title and commit message. of course it's a PR because it is

also please remove "all tests pass", we have ci checks in place which will be the judge of that

pyflakes/checker.py Outdated
@@ -1773,6 +1761,7 @@ def DICT(self, node):
# Complain if there are duplicate keys with different values
# If they have the same value it's not going to cause potentially
# unexpected behaviour so we'll not complain.
counter = collections.Counter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should fix the call, this line looks suspicious as written

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile rev 2d8f8de does as you requested.

@edreamleo
Copy link
Contributor Author

@asottile Thanks for your guidance.

@edreamleo edreamleo changed the title PR: Replace 'counter' function with 'collection.Counter' Replace 'counter' function with 'collection.Counter' Jun 26, 2024
@edreamleo
Copy link
Contributor Author

@asottile I would rather not change a previous commit message, but feel free to change it if think it's best.

@sigmavirus24 sigmavirus24 merged commit ac563ed into PyCQA:main Jun 28, 2024
9 checks passed
@edreamleo
Copy link
Contributor Author

@sigmavirus24 Thanks, Ian.

@sigmavirus24
Copy link
Member

Thanks for helping improve the project, @edreamleo

@edreamleo
Copy link
Contributor Author

@sigmavirus24 You're welcome :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile left review comments

@sigmavirus24 sigmavirus24 sigmavirus24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edreamleo @sigmavirus24 @asottile