-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds unit tests to assure randomness #770
Conversation
There's a lot of good stuff in here that I don't want to lose, however there are two points to have another think about:
Dice are supposed to be 'predicatably unpredicatable'. By salting the seed with the initial date, I feel like we lose a bit of that. Now, I don't know in practice if it makes a great deal of difference: Is anyone really testing that way? Seems unlikely, but I'm also not sure if adding the date will improve the issue being reported. If not then it's an arbitrary change we don't need. |
Branch needs a rebase. |
62372fc
to
02f687b
Compare
Done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change to make then I'm happy to merge. Thanks.
Tests now run 3 lots of 200,000,000 rolls of dice and check the distribution of the results in order to test the assertion made in #750
ff91fdb
to
2b130d0
Compare
Tests now run 3 lots of 200,000,000 rolls of dice and check the distribution of the results in order to test the assertion made in #750
There's a minor code cleanup here too, but nothing breaking (just re-using a method rather than having 2 similar methods)