item timer bug and speed by level bug #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotfix/timer bug
…s and speed-up item
…em effect to �enhance ship speed based on current speed
Hotfix/original speed
bysxx
reviewed
Oct 21, 2023
| this.ship.setShootingInterval(1000); | ||
| if (gameState.getMode()==2) { | ||
| this.ship2.resetSpeed(); | ||
| this.ship2.setOriginalSpeed(2); |
There was a problem hiding this comment.
기존에 reset되던 부분이 set~(2)로 바뀌었는데 의도된 수정일까요?
There was a problem hiding this comment.
level 팀에서 스피드를 2로 변경하는 것을 의도하신 것 같아서 저렇게 변경해두었습니다. level 팀의 리뷰가 필요합니다.
| this.ship.setShootingInterval(1100); | ||
| if (gameState.getMode()==2) { | ||
| this.ship2.resetSpeed(); | ||
| this.ship2.setOriginalSpeed(2); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.