Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update default power reduction to 1e18 #905

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

zakir-code
Copy link
Contributor

@zakir-code zakir-code commented Jan 15, 2025

Summary by CodeRabbit

Release Notes

  • Tests

    • Enhanced test coverage for token conversion and power reduction methods
    • Added new test cases for validating token-to-consensus power conversions
    • Updated balance and delegation amount calculations in existing test suites
  • Refactor

    • Simplified constant initialization for power reduction
    • Streamlined test code for staking and share transfer operations
  • Bug Fixes

    • Adjusted token amount calculations to ensure accurate testing scenarios

Copy link

coderabbitai bot commented Jan 15, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces modifications across multiple files in the project, focusing on testing and constant definitions. The changes primarily involve adjusting balance expectations in client tests, modifying staking share transfer tests, and simplifying the DefaultPowerReduction constant initialization. The modifications aim to refine test cases and simplify constant calculations, with a particular emphasis on token and power-related computations.

Changes

File Change Summary
client/client_test.go Modified balance expectations in TestClient_Query method, reducing the expected balance amount for the first validator's address
precompiles/staking/transfer_shares_test.go Adjusted delAmount calculation, reduced scale from Mul(sdkmath.NewInt(1e18)) to MulRaw(1e16), added new test cases for share transfers
types/constant.go Simplified sdk.DefaultPowerReduction initialization from complex math/big calculation to sdkmath.NewInt(1e18)
types/constant_test.go Added new Test_PowerReduction function to validate TokensToConsensusPower method behavior

Sequence Diagram

sequenceDiagram
    participant Test as Test Suite
    participant Constant as Power Reduction
    participant TokenConverter as Token Converter

    Test->>Constant: Set DefaultPowerReduction
    Constant-->>Test: Confirm reduction value
    Test->>TokenConverter: Convert tokens to consensus power
    TokenConverter-->>Test: Validate conversion limits
Loading

Possibly related PRs

Poem

🐰 A rabbit's tale of code so bright,
Where constants dance and tests take flight,
Balances shift, power reduces neat,
Our computational warren's a testing treat!
Hop, hop, hurrah for cleaner code! 🧪


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ed93298 and 3c40f22.

📒 Files selected for processing (4)
  • client/client_test.go (2 hunks)
  • precompiles/staking/transfer_shares_test.go (2 hunks)
  • types/constant.go (1 hunks)
  • types/constant_test.go (2 hunks)

Finishing Touches

  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@zakir-code
Copy link
Contributor Author

@coderabbitai review

Copy link

coderabbitai bot commented Jan 15, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@zakir-code zakir-code merged commit a740c2c into main Jan 15, 2025
12 checks passed
@zakir-code zakir-code deleted the zakir/staking-params branch January 15, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant