fix(x/crosschain): ensure crosschain ibcTransfer fee is zero

[zakir-code]

Summary by CodeRabbit

• Bug Fixes
  • Enhanced validation for IBC cross-chain transfers
  • Corrected fee handling during token transfers
  • Improved error checking for cross-chain transaction parameters

[coderabbitai]

Walkthrough

The pull request modifies the CrosschainBaseCoin method in the crosschain keeper, introducing a new validation check for IBC transfers. Specifically, it enforces that the fee must be zero during IBC transfers and changes the cache-setting logic for origin tokens. The modification ensures stricter fee handling during cross-chain transactions, particularly for Inter-Blockchain Communication (IBC) transfers.

Changes

File	Change Summary
x/crosschain/keeper/bridge_call_out.go	Updated CrosschainBaseCoin method to validate IBC transfer fees and modify cache-setting logic for origin tokens

Possibly related PRs

• fix: transfer bridge fee #878: Changes to fee handling logic in bridge_call_out.go, directly related to the fee validation modifications in this PR

Poem

🐰 Hopping through blockchains with care,
A rabbit checks each transfer's fare
Zero fees for IBC's light,
Caching tokens just right
Cross-chain magic beyond compare! 🌉

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9020cc4 and 9321585.

📒 Files selected for processing (1)

• x/crosschain/keeper/bridge_call_out.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Mergify Merge Protections
• GitHub Check: Summary

🔇 Additional comments (2)

x/crosschain/keeper/bridge_call_out.go (2)

344-346: LGTM! Fee validation for IBC transfers.

The added validation ensures that IBC transfers have zero fees, which aligns with the PR objective.

---

352-352: Verify the cache-setting behavior.

The cache is now set with just the amount for origin tokens in IBC transfers. Please ensure this change doesn't affect existing functionality.

Run the following script to check for any other cache-setting patterns in the codebase:

✅ Verification successful

Cache setting behavior for IBC transfers is consistent

The cache is designed to store only the amount for IBC transfers, as evidenced by consistent usage patterns across the codebase, migration code, and test cases. This change maintains the intended behavior.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for cache-setting patterns in IBC transfers
# Expected: Only amount should be cached for IBC transfers

# Search for cache-setting patterns
ast-grep --pattern 'SetCache($_, $_, $_)'

# Search for IBC transfer related code
rg -A 5 'IBCTransfer|NewIBCTransferKey'

Length of output: 18892

Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.