-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(upgrade): update layer2 oracle to online #875
Conversation
WalkthroughThe pull request introduces enhancements to the upgrade testing framework, specifically focusing on verifying the online status of layer 2 oracles. A new function Changes
Sequence DiagramsequenceDiagram
participant Test as Upgrade Test
participant Layer2Keeper as Layer2 Keeper
participant Oracle as Layer 2 Oracles
Test->>Layer2Keeper: Get list of oracles
Layer2Keeper-->>Test: Return oracle list
loop For Each Oracle
Test->>Oracle: Check Online Status
Oracle-->>Test: Confirm Online Status
end
Test->>Layer2Keeper: Fix Base Oracle Status
Layer2Keeper->>Oracle: Update Online Status
Possibly Related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
app/upgrades/v8/upgrade.go (1)
Line range hint
391-403
: Add logging for oracle status changes and validate oracle addresses.The function correctly fixes oracle status but could benefit from:
- Logging oracle status changes for better debugging and auditing.
- Validating oracle addresses before updating their status.
Apply this diff to add logging and validation:
func fixBaseOracleStatus(ctx sdk.Context, crosschainKeeper crosschainkeeper.Keeper) { if crosschainKeeper.ModuleName() != layer2types.ModuleName { return } oracles := crosschainKeeper.GetAllOracles(ctx, false) for _, oracle := range oracles { + if err := sdk.VerifyAddressFormat([]byte(oracle.OracleAddress)); err != nil { + ctx.Logger().Error("invalid oracle address", "address", oracle.OracleAddress, "error", err) + continue + } + ctx.Logger().Info("fixing oracle status", + "address", oracle.OracleAddress, + "previous_online", oracle.Online, + "previous_slash_times", oracle.SlashTimes, + "previous_start_height", oracle.StartHeight) oracle.Online = true oracle.SlashTimes = 0 oracle.StartHeight = ctx.BlockHeight() crosschainKeeper.SetOracle(ctx, oracle) } crosschainKeeper.SetLastTotalPower(ctx) }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
app/upgrade_test.go
(3 hunks)app/upgrades/v8/upgrade.go
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Mergify Merge Protections
- GitHub Check: Summary
🔇 Additional comments (4)
app/upgrade_test.go (3)
34-34
: LGTM!The added import for the crosschain keeper is necessary for the new oracle verification functionality.
175-180
: LGTM! Well-structured oracle verification function.The function effectively verifies the online status of all oracles with clear error messages that include the oracle address for debugging.
88-88
: LGTM! Appropriate placement of oracle verification.The oracle verification is correctly placed after the upgrade execution in both test functions.
Also applies to: 172-172
app/upgrades/v8/upgrade.go (1)
69-69
: LGTM! Appropriate placement of oracle status fix.The oracle status fix is correctly placed before token-related operations in the upgrade process.
Summary by CodeRabbit
New Features
Bug Fixes