Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set upgrade height for testnet v8 #857

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

zakir-code
Copy link
Contributor

@zakir-code zakir-code commented Jan 2, 2025

Summary by CodeRabbit

  • New Features
    • Added support for testnet version 8 with a specific block height marker
  • Chores
    • Updated blockchain versioning constants to include new testnet version

Copy link

coderabbitai bot commented Jan 2, 2025

Walkthrough

The pull request introduces a new testnet block height constant TestnetBlockHeightV8 in the types/version.go file, set to 18_005_000. Correspondingly, the cmd/doctor.go file is updated to include a condition that checks for this new block height and prints the version as "V8" when the condition is met. This change appears to be part of an ongoing versioning strategy for the blockchain's testnet, allowing for more granular version recognition based on block height.

Changes

File Change Summary
types/version.go Added new constant TestnetBlockHeightV8 with value 18_005_000
cmd/doctor.go Updated checkBlockchainData function to include a condition for printing "V8" version when block height meets the new threshold

Possibly related PRs

  • feat: add v7.2 version check #488: Modification of checkBlockchainData function in cmd/doctor.go with a similar approach to version checking based on testnet block height

Poem

🐰 Blockchain's version, a tale to tell
A new height rises, casting its spell
V8 emerges, block by block
Testnet's progress, a rhythmic clock
Rabbit hops through version's gate
Coding magic, simply great! 🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3556b71 and df629a5.

📒 Files selected for processing (2)
  • cmd/doctor.go (1 hunks)
  • types/version.go (1 hunks)
🔇 Additional comments (1)
types/version.go (1)

39-39: Addition of TestnetBlockHeightV8 constant looks good.

Everything seems consistent with the existing naming scheme for other testnet block height constants. Ensure that this block height accurately corresponds to the correct activation point for the v8 upgrade.

cmd/doctor.go Show resolved Hide resolved
@zakir-code zakir-code merged commit 0be9a5f into main Jan 2, 2025
13 checks passed
@zakir-code zakir-code deleted the zakir/upgrade-v8 branch January 2, 2025 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant