Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add gci/dogsled/gosec/errcheckl linters #105

Merged
merged 10 commits into from
Oct 30, 2023
Merged

chore: add gci/dogsled/gosec/errcheckl linters #105

merged 10 commits into from
Oct 30, 2023

Conversation

zakir-code
Copy link
Contributor

  • use gci replace goimports-reviser

@zakir-code zakir-code requested a review from fx0x55 October 27, 2023 11:19
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 27, 2023
View reviewed changes
x/erc20/types/msg.go Fixed Show resolved Hide resolved
x/erc20/types/events.go Fixed Show fixed Hide fixed
server/config/flags.go Fixed Show fixed Hide fixed
server/config/flags.go Fixed Show fixed Hide fixed
fx0x55
fx0x55 reviewed Oct 27, 2023
View reviewed changes
x/erc20/types/msg.go Outdated Show resolved Hide resolved
fx0x55
fx0x55 requested changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@fx0x55 fx0x55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zakir-code lint checks failed, has warnings

fx0x55
fx0x55 reviewed Oct 28, 2023
View reviewed changes
Copy link
Contributor

@fx0x55 fx0x55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other msg GetSigners() also need to be consistent

return []sdk.AccAddress{sdk.MustAccAddressFromBech32(m.Authority)}

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 28, 2023
View reviewed changes
x/erc20/types/msg.go Fixed Show fixed Hide fixed
x/erc20/types/events.go Fixed Show fixed Hide fixed
server/config/flags.go Fixed Show fixed Hide fixed
server/config/flags.go Fixed Show fixed Hide fixed
@zakir-code zakir-code self-assigned this Oct 28, 2023
fx0x55
fx0x55 reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@fx0x55 fx0x55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zakir-code Fix them, MsgUpdateChainOracles and MsgUpdateEGFParams

x/gov/types/msgs.go Outdated Show resolved Hide resolved
x/crosschain/types/msgs.go Outdated Show resolved Hide resolved
@zakir-code zakir-code requested a review from fx0x55 October 30, 2023 07:01
@fx0x55 fx0x55 merged commit 4d190da into main Oct 30, 2023
7 checks passed
@fx0x55 fx0x55 deleted the zakir/make-lint branch October 30, 2023 07:09
@zakir-code zakir-code mentioned this pull request Oct 31, 2023
Merged
zakir-code added a commit that referenced this pull request Feb 8, 2024
@zakir-code @github-actions
feat: add MsgBridgeCallClaim to crosschain (#105)
25f10a8
zakir-code added a commit to zakir-code/fx-core that referenced this pull request May 24, 2024
@zakir-code
feat: add MsgBridgeCallClaim to crosschain (PundiAI#105)
3e09200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fx0x55 fx0x55 fx0x55 approved these changes

Assignees

@zakir-code zakir-code

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zakir-code @fx0x55